Changes to follow the JSON style guide

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Changes to follow the JSON style guide

lcestari
Hi guys,

I was thinking about to create a issue for each repository to check if we are following the JSON guide, what do you think? For instance, the following code seems not following it:

https://github.com/lightblue-platform/lightblue-core/blob/00207aa9bd4d6bef30c754d150f5af9b8832f345/query-api/src/main/java/com/redhat/lightblue/query/BinaryComparisonOperator.java#L28-L33

http://docs.lightblue.io/standards/style_guide.html
Reply | Threaded
Open this post in threaded view
|

Re: Changes to follow the JSON style guide

bserdar
ok for issues about json guide, but what part of that code doesn't
follow the json guides? In particular, that piece of code has got
nothing to do with JSON, it is the names of the operators.

On Tue, Sep 2, 2014 at 10:14 AM, lcestari [via lightblue-dev]
<[hidden email]> wrote:

> Hi guys,
>
> I was thinking about to create a issue for each repository to check if we
> are following the JSON guide, what do you think? For instance, the following
> code seems not following it:
>
> https://github.com/lightblue-platform/lightblue-core/blob/00207aa9bd4d6bef30c754d150f5af9b8832f345/query-api/src/main/java/com/redhat/lightblue/query/BinaryComparisonOperator.java#L28-L33
>
> http://docs.lightblue.io/standards/style_guide.html
>
> ________________________________
> If you reply to this email, your message will be added to the discussion
> below:
> http://dev.forum.lightblue.io/Changes-to-follow-the-JSON-style-guide-tp128.html
> To start a new topic under lightblue-dev, email
> [hidden email]
> To unsubscribe from lightblue-dev, click here.
> NAML
Reply | Threaded
Open this post in threaded view
|

Re: Changes to follow the JSON style guide

lcestari
Sorry, It doesnt say that but I thought that Naveen and I discussed that as that happened in RDBMS module and it seems to be very concise if even in the enumeration we avoid the to use special character such '$'.
Reply | Threaded
Open this post in threaded view
|

Re: Changes to follow the JSON style guide

jewzaam
Administrator

It wasn't clear. I personally like the $ for the cases like operator enemy. Should it be allowed there? The standard isn't enforced in any way other than manually meaning exceptions will happen and the standard will change. I think this is OK to have in. Hopefully I'm not contradicting a previous post of mine :)

On Sep 5, 2014 5:38 PM, "lcestari [via lightblue-dev]" <[hidden email]> wrote:
Sorry, It doesnt say that but I thought that Naveen and I discussed that as that happened in RDBMS module and it seems to be very concise if even in the enumeration we avoid the to use special character such '$'.


If you reply to this email, your message will be added to the discussion below:
http://dev.forum.lightblue.io/Changes-to-follow-the-JSON-style-guide-tp128p142.html
To start a new topic under lightblue-dev, email [hidden email]
To unsubscribe from lightblue-dev, click here.
NAML
Reply | Threaded
Open this post in threaded view
|

Re: Changes to follow the JSON style guide

bserdar
In reply to this post by lcestari
I like the $ in operators and keywords too, but that doesn't mean we
can't change it. But again, why? In my opinion, it makes more sense to
change the standard.

On Fri, Sep 5, 2014 at 3:38 PM, lcestari [via lightblue-dev]
<[hidden email]> wrote:

> Sorry, It doesnt say that but I thought that Naveen and I discussed that as
> that happened in RDBMS module and it seems to be very concise if even in the
> enumeration we avoid the to use special character such '$'.
>
> ________________________________
> If you reply to this email, your message will be added to the discussion
> below:
> http://dev.forum.lightblue.io/Changes-to-follow-the-JSON-style-guide-tp128p142.html
> To start a new topic under lightblue-dev, email
> [hidden email]
> To unsubscribe from lightblue-dev, click here.
> NAML