Put more details on PR

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Put more details on PR

lcestari
I noticed that often the PR doesn't have the milestone which it want that to be merged or even the the reference to the issue that needs that to be merged. I would recommend that we put these informations (and other, like labels, if needed ) to make more rich issues/PRs, so we can easily see the PR of a release (for metrics for example), etc.

Also, github have a guide which describe some pro tips that is very nice (and expose the two models of using the git/github and other things) -> https://guides.github.com/introduction/flow/index.html

Another helpful cheat sheet about github -> https://github.com/tiimgreen/github-cheat-sheet
Reply | Threaded
Open this post in threaded view
|

Re: Put more details on PR

jewzaam
Administrator
If you use waffle.io and have linked the PR to the issue correctly the issue is what is displayed in the column and it does have the milestone.

On Tue Jan 20 2015 at 2:47:29 PM lcestari [via lightblue-dev] <[hidden email]> wrote:
I noticed that often the PR doesn't have the milestone which it want that to be merged or even the the reference to the issue that needs that to be merged. I would recommend that we put these informations (and other, like labels, if needed ) to make more rich issues/PRs, so we can easily see the PR of a release (for metrics for example), etc.

Also, github have a guide which describe some pro tips that is very nice (and expose the two models of using the git/github and other things) -> https://guides.github.com/introduction/flow/index.html

Another helpful cheat sheet about github -> https://github.com/tiimgreen/github-cheat-sheet


If you reply to this email, your message will be added to the discussion below:
http://dev.forum.lightblue.io/Put-more-details-on-PR-tp311.html
To start a new topic under lightblue-dev, email [hidden email]
To unsubscribe from lightblue-dev, click here.
NAML
Reply | Threaded
Open this post in threaded view
|

Re: Put more details on PR

jewzaam
Administrator
In reply to this post by lcestari
I guess the issue is for "naked" PR's, those that don't have an issue associated?

On Tue Jan 20 2015 at 2:58:00 PM Juzam <[hidden email]> wrote:
If you use waffle.io and have linked the PR to the issue correctly the issue is what is displayed in the column and it does have the milestone.

On Tue Jan 20 2015 at 2:47:29 PM lcestari [via lightblue-dev] <[hidden email]> wrote:
I noticed that often the PR doesn't have the milestone which it want that to be merged or even the the reference to the issue that needs that to be merged. I would recommend that we put these informations (and other, like labels, if needed ) to make more rich issues/PRs, so we can easily see the PR of a release (for metrics for example), etc.

Also, github have a guide which describe some pro tips that is very nice (and expose the two models of using the git/github and other things) -> https://guides.github.com/introduction/flow/index.html

Another helpful cheat sheet about github -> https://github.com/tiimgreen/github-cheat-sheet


If you reply to this email, your message will be added to the discussion below:
http://dev.forum.lightblue.io/Put-more-details-on-PR-tp311.html
To start a new topic under lightblue-dev, email [hidden email]
To unsubscribe from lightblue-dev, click here.
NAML
Reply | Threaded
Open this post in threaded view
|

Re: Put more details on PR

lcestari
About naked PR, yes, so there is an issue but it is not associated.

About waffle.io, that's true, but I'm worried if we just rely on the waffle.io database as these informations are not persisted on GitHub (just to explain better my worry about this aspect, we already used many different tools to manage the issue, maybe waffle would not be the last one)

Note: I'm not looking for the ultimate tool or sth like it, just in case we find another better tool and if we miss something during the migration.
Note: I would guess that maybe be GitHub will come up with a better issue manager with reports and etc.
Note: I also used this post to provide those links that might be pretty helpful for the developers that want to contribute to lightblue.