Ready for review VS in progress

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

Ready for review VS in progress

jewzaam
Administrator
When reviewing a change, should we move it back to in progress if there is something wrong?  I'm more inclined to leave it in ready for review for very minor updates, only shift back to in progress for something big.

Thoughts?
Reply | Threaded
Open this post in threaded view
|

Re: Ready for review VS in progress

jewzaam
Administrator
Or if it isn't clear if it's really done (for example https://github.com/lightblue-platform/lightblue/issues/30#issuecomment-51849923) I would leave it in ready for review.
Reply | Threaded
Open this post in threaded view
|

Re: Ready for review VS in progress

lcestari
Sorry, I thought you already reviewed it (and I remember you said something like that issue in one of our daily scrum but I thought it was an old issue, not this one). I think we can leave in the review queue but it might happen this problem again (or the other way around, like, I didn't review the remaining issues that was about metadata mgmt due I thought Derek was looking, so maybe we were on Livelock problem). So I would consider create a new queue (so we know which issues new someone to take a look and the other that some is already working on)
Reply | Threaded
Open this post in threaded view
|

Re: Ready for review VS in progress

jewzaam
Administrator
+1 had the same thought last night.  How about we keep the "Ready for Review" as the staging area and add "In Review" or something similar for those that are being reviewed?
Regarding moving back to in progress.  It would be simplest to put things back to In Progress if they need questions answered or have problems to fix.  Given we keep owner of an issue as the one doing the work, that person will see it in the In Progress list with their name.  And just put back to ready for review when answered or fixed.


On Fri, Aug 15, 2014 at 9:58 AM, lcestari [via lightblue-dev] <[hidden email]> wrote:
Sorry, I thought you already reviewed it (and I remember you said something like that issue in one of our daily scrum but I thought it was an old issue, not this one). I think we can leave in the review queue but it might happen this problem again (or the other way around, like, I didn't review the remaining issues that was about metadata mgmt due I thought Derek was looking, so maybe we were on Livelock problem). So I would consider create a new queue (so we know which issues new someone to take a look and the other that some is already working on)


If you reply to this email, your message will be added to the discussion below:
http://lightblue-dev.1011138.n3.nabble.com/Ready-for-review-VS-in-progress-tp44p46.html
To start a new topic under lightblue-dev, email [hidden email]
To unsubscribe from lightblue-dev, click here.
NAML

Reply | Threaded
Open this post in threaded view
|

Re: Ready for review VS in progress

lcestari
For me that seems awesome =) Should we write down this workflow somewhere?

Luan Cestari | Senior Software Applications Engineer
IT Shared Services
M: +55 11 99602-7887
<img src="http://images.engage.redhat.com/eloquaimages/clients/RedHat/{a8aabf3a-4467-4e37-9bc5-48b1d7b494a2}_LATAM_RedHat.jpg" alt="Red Hat" border="0" data-mce-src="http://images.engage.redhat.com/eloquaimages/clients/RedHat/{a8aabf3a-4467-4e37-9bc5-48b1d7b494a2}_LATAM_RedHat.jpg" data-mce-style="font-family: Arial; font-size: 13px;" style="font-family: Arial; font-size: 13px;">
Better technology. Faster innovation. Powered by community collaboration. 
See how it works at www.redhat.com
 




From: "jewzaam [via lightblue-dev]" <[hidden email]>
To: "lcestari" <[hidden email]>
Sent: Friday, August 15, 2014 11:23:35 AM
Subject: Re: Ready for review VS in progress

+1 had the same thought last night.  How about we keep the "Ready for Review" as the staging area and add "In Review" or something similar for those that are being reviewed?
Regarding moving back to in progress.  It would be simplest to put things back to In Progress if they need questions answered or have problems to fix.  Given we keep owner of an issue as the one doing the work, that person will see it in the In Progress list with their name.  And just put back to ready for review when answered or fixed.


On Fri, Aug 15, 2014 at 9:58 AM, lcestari [via lightblue-dev] <[hidden email]> wrote:
Sorry, I thought you already reviewed it (and I remember you said something like that issue in one of our daily scrum but I thought it was an old issue, not this one). I think we can leave in the review queue but it might happen this problem again (or the other way around, like, I didn't review the remaining issues that was about metadata mgmt due I thought Derek was looking, so maybe we were on Livelock problem). So I would consider create a new queue (so we know which issues new someone to take a look and the other that some is already working on)


If you reply to this email, your message will be added to the discussion below:
http://lightblue-dev.1011138.n3.nabble.com/Ready-for-review-VS-in-progress-tp44p46.html
To start a new topic under lightblue-dev, email [hidden email]
To unsubscribe from lightblue-dev, click here.
NAML




If you reply to this email, your message will be added to the discussion below:
http://lightblue-dev.1011138.n3.nabble.com/Ready-for-review-VS-in-progress-tp44p47.html
To start a new topic under lightblue-dev, email [hidden email]
To unsubscribe from lightblue-dev, click here.
NAML

Reply | Threaded
Open this post in threaded view
|

Re: Ready for review VS in progress

jewzaam
Administrator
I added "In Review".  Yes, we should write it down.  I have the developer gitbook open, I'll see about getting a rough outline documented.
Reply | Threaded
Open this post in threaded view
|

Re: Ready for review VS in progress

jewzaam
Administrator
Reply | Threaded
Open this post in threaded view
|

Re: Ready for review VS in progress

lcestari
Do you think it worth to put the travis link when you mention it (or maybe put in the very beginning of the article)(this maybe not necessary as the link will be on the end of PR)? I also thought about citing the coveralls.io as well. What do you think guys?

Luan Cestari | Senior Software Applications Engineer
IT Shared Services
M: +55 11 99602-7887
<img src="http://images.engage.redhat.com/eloquaimages/clients/RedHat/{a8aabf3a-4467-4e37-9bc5-48b1d7b494a2}_LATAM_RedHat.jpg" alt="Red Hat" border="0" data-mce-src="http://images.engage.redhat.com/eloquaimages/clients/RedHat/{a8aabf3a-4467-4e37-9bc5-48b1d7b494a2}_LATAM_RedHat.jpg" data-mce-style="font-family: Arial; font-size: 13px;" style="font-family: Arial; font-size: 13px;">
Better technology. Faster innovation. Powered by community collaboration. 
See how it works at www.redhat.com
 





From: "jewzaam [via lightblue-dev]" <[hidden email]>
To: "lcestari" <[hidden email]>
Sent: Friday, August 15, 2014 12:52:11 PM
Subject: Re: Ready for review VS in progress

See https://github.com/lightblue-platform/lightblue-docs-developer/commit/33281b637d2bc07d3a0367e3947913d0936f8a7c


If you reply to this email, your message will be added to the discussion below:
http://lightblue-dev.1011138.n3.nabble.com/Ready-for-review-VS-in-progress-tp44p50.html
To start a new topic under lightblue-dev, email [hidden email]
To unsubscribe from lightblue-dev, click here.
NAML

Reply | Threaded
Open this post in threaded view
|

Re: Ready for review VS in progress

jewzaam
Administrator
In reply to this post by jewzaam
"In Review" has been removed.  Wasn't really used.